it'd be nice to have a configurable bootstrap option for which headers to inline so folks could optimize on their own.

FWIW when I wrote the custom inline header code I intended to eventually make it bootstrap configurable. It should be quite easy:

envoy/source/server/server.cc

Lines 350 to 362 in d3a9012

    
           // Immediate after the bootstrap has been loaded, override the header prefix, if configured to 
        
           // do so. This must be set before any other code block references the HeaderValues ConstSingleton. 
        
           if (!bootstrap_.header_prefix().empty()) { 
        
             // setPrefix has a release assert verifying that setPrefix() is not called after prefix() 
        
             ThreadSafeSingleton<Http::PrefixValue>::get().setPrefix(bootstrap_.header_prefix().c_str()); 
        
           } 
        
           // TODO(mattklein123): Custom O(1) headers can be registered at this point for creating/finalizing 
        
           // any header maps. 
        
           ENVOY_LOG(info, "HTTP header map info:"); 
        
           for (const auto& info : Http::HeaderMapImplUtility::getAllHeaderMapImplInfo()) { 
        
             ENVOY_LOG(info, "  {}: {} bytes: {}", info.name_, info.size_, 
        
                       absl::StrJoin(info.registered_headers_, ",")); 
        
           }

	// Immediate after the bootstrap has been loaded, override the header prefix, if configured to
	// do so. This must be set before any other code block references the HeaderValues ConstSingleton.
	if (!bootstrap_.header_prefix().empty()) {
	// setPrefix has a release assert verifying that setPrefix() is not called after prefix()
	ThreadSafeSingleton<Http::PrefixValue>::get().setPrefix(bootstrap_.header_prefix().c_str());
	}
	// TODO(mattklein123): Custom O(1) headers can be registered at this point for creating/finalizing
	// any header maps.
	ENVOY_LOG(info, "HTTP header map info:");
	for (const auto& info : Http::HeaderMapImplUtility::getAllHeaderMapImplInfo()) {
	ENVOY_LOG(info, " {}: {} bytes: {}", info.name_, info.size_,
	absl::StrJoin(info.registered_headers_, ","));
	}

inline http cookie header #17234

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions