-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Closed
Labels
area/wasmenhancementFeature requests. Not bugs or questions.Feature requests. Not bugs or questions.
Description
It will be troublesome not to allow just identifying gRPC target host name as grpcCall argument. Specifically, we should provide fallback mechanism if GrpcService parse failed from bytes stream.
envoy/source/extensions/common/wasm/context.cc
Lines 981 to 984 in c8fb3a5
| GrpcService service_proto; | |
| if (!service_proto.ParseFromArray(grpc_service.data(), grpc_service.size())) { | |
| return WasmResult::ParseFailure; | |
| } |
We will get into some trouble without this feature when we introduce support gRPC client from proxy-wasm SDK such as Rust. (It doesn't have gRPC client support right now), because it will be required new code for the desired language generated from Envoy API proto.
My expected behavior is when we failed to parse bytes stream, then try to parse the bytes stream as hostname. We will get ParseFailure after failed to parse hostname.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area/wasmenhancementFeature requests. Not bugs or questions.Feature requests. Not bugs or questions.