Skip to content

Fallback when GrpcService parse failed to create gRPC call on wasm #15170

@Shikugawa

Description

@Shikugawa

It will be troublesome not to allow just identifying gRPC target host name as grpcCall argument. Specifically, we should provide fallback mechanism if GrpcService parse failed from bytes stream.

GrpcService service_proto;
if (!service_proto.ParseFromArray(grpc_service.data(), grpc_service.size())) {
return WasmResult::ParseFailure;
}

We will get into some trouble without this feature when we introduce support gRPC client from proxy-wasm SDK such as Rust. (It doesn't have gRPC client support right now), because it will be required new code for the desired language generated from Envoy API proto.

My expected behavior is when we failed to parse bytes stream, then try to parse the bytes stream as hostname. We will get ParseFailure after failed to parse hostname.

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/wasmenhancementFeature requests. Not bugs or questions.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions