-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Closed
Closed
Copy link
Labels
Description
I am using ECDS to provide dynamic extension configuration. When listener updates, dynamic filter config provider will return empty config for the new listener:
| return tls_->config_; |
I think what happens is that when listener updates, old listener takes time to drain, ECDS subscription is not destroyed when new listener is constructed, so it is reused by the new listener:
| auto it = subscriptions_.find(subscription_id); |
But a new dynamic filter config provider is created with the new listener and will be warming and wait for any subscription update:
| auto filter_config_provider = filter_config_provider_manager_.createDynamicFilterConfigProvider( |
However, when subscription receives new update, if config does not have any change from last update, it will skip updating provider. Listener will be considered as warmed, and provider will stuck with empty config until next ECDS update with diff.
| if (new_hash == last_config_hash_) { |
Reactions are currently unavailable