-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Open
Labels
Description
We recently ran into an internal problem where an in-house filter was returning a local reply and immediately after returning FilterHeaderStatus::Continue, which ends up confusing the Router filter machinery.
A few things can be done to improve the experience for filter developers:
-
improve docs around the contract with filters (e.g.: filter: clarify comment #13678, I'll send another one for docs/root/faq/extensions/contract.rst as well)
-
enforce more checks to ensure callbacks cannot be called after a local reply has been sent
-
more assertions around the filter chain state machine
Reactions are currently unavailable