Skip to content

Teach domains to allow trailing wildcards / unknown ports in Host #1269

@cmaloney

Description

@cmaloney

The "domains" configuration within a virtual_hosts of a route config allows wildcards at the start of the domain currently, but not the tail.

This means If I do something (like for local development) where I run envoy on port 8080 locally with a name based virtual host / domains set (ideally the same one i'm going to be deploying), I have to match the port exactly inside the domains, otherwise the request doesn't match and I get a 404 from envoy, which has no immediate debugging feedback as to why it's happening

Open to writing up a patch to help implement this, but not sure what's the approach that would be preferred:

  1. Match domains excluding the port
  2. Allow "trailing" wildcards, so things like example.com:80*, example.com:* would properly function

Some other option I haven't thought of here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementFeature requests. Not bugs or questions.help wantedNeeds help!

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions