Skip to content

Windows: yaml-cpp errors when files are checked out on Windows with CRLF line endings #11659

@sunjayBhatia

Description

@sunjayBhatia

Currently we have had to mark some tests as failing on Windows when the Envoy codebase is checked out with CRLF line endings. yaml-cpp fails to parse test fixtures and errors with something like: yaml: line 3: mapping values are not allowed in this context

Current (possibly non exhaustive) list of tests affected:

  • //test/common/buffer:watermark_buffer_test
  • //test/common/runtime:runtime_impl_test
  • //test/exe:main_common_test
  • //test/integration:dynamic_validation_integration_test
  • //test/server:server_test

We should be able to support parsing configs with any valid line ending (or make a policy that this is not the case) and add tests that run cross-platform to ensure files with CRLF and LF line endings are parsed correctly.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions