Fix clang-tidy errors

sunjayBhatia · wrowe · sunjayBhatia · commit 6ab3de8b3afc · 2020-06-19T10:06:46.000-04:00
- typedef instead of using in platform.h
- exclude win32 completely

Signed-off-by: Sunjay Bhatia &lt;sunjayb@vmware.com&gt;
Co-authored-by: Sunjay Bhatia &lt;sunjayb@vmware.com&gt;
Signed-off-by: William A Rowe Jr &lt;wrowe@vmware.com&gt;
Co-authored-by: William A Rowe Jr &lt;wrowe@vmware.com&gt;
diff --git a/ci/run_clang_tidy.sh b/ci/run_clang_tidy.sh
@@ -37,7 +37,7 @@ trap cleanup EXIT
 # TODO(scw00): We should run clang-tidy against win32 impl. But currently we only have 
 # linux ci box.
 function exclude_win32_impl() {
-  grep -v source/common/filesystem/win32/ | grep -v source/common/common/win32 | grep -v source/exe/win32
+  grep -v source/common/filesystem/win32/ | grep -v source/common/common/win32 | grep -v source/exe/win32 | grep -v source/common/api/win32
 }
 
 # Do not run incremental clang-tidy on check_format testdata files.
diff --git a/include/envoy/common/platform.h b/include/envoy/common/platform.h
@@ -53,13 +53,13 @@
   __pragma(pack(push, 1)) definition, ##__VA_ARGS__;                                               \
   __pragma(pack(pop))
 
-using ssize_t = ptrdiff_t;
+typedef ptrdiff_t ssize_t;
 
 // This is needed so the OsSysCalls interface compiles on Windows,
 // shmOpen takes mode_t as an argument.
-using mode_t = uint32_t;
+typedef uint32_t mode_t;
 
-using os_fd_t = SOCKET;
+typedef SOCKET os_fd_t;
 
 typedef unsigned int sa_family_t;
 
@@ -188,7 +188,7 @@ struct msghdr {
 #define IP6T_SO_ORIGINAL_DST 80
 #endif
 
-using os_fd_t = int;
+typedef int os_fd_t;
 
 #define INVALID_SOCKET -1
 #define SOCKET_VALID(sock) ((sock) >= 0)

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ trap cleanup EXIT`
`37`	`37`	`# TODO(scw00): We should run clang-tidy against win32 impl. But currently we only have`
`38`	`38`	`# linux ci box.`
`39`	`39`	`function exclude_win32_impl() {`
`40`		`- grep -v source/common/filesystem/win32/ \| grep -v source/common/common/win32 \| grep -v source/exe/win32`
	`40`	`+ grep -v source/common/filesystem/win32/ \| grep -v source/common/common/win32 \| grep -v source/exe/win32 \| grep -v source/common/api/win32`
`41`	`41`	`}`
`42`	`42`
`43`	`43`	`# Do not run incremental clang-tidy on check_format testdata files.`