build: bazel support for importing to envoy repository.#73
Conversation
|
@junr03 for review. |
api/BUILD
Outdated
| @@ -1,5 +1,17 @@ | |||
| load("//bazel:api_build_system.bzl", "api_proto_library") | |||
|
|
|||
| cc_library( | |||
There was a problem hiding this comment.
Do we want to bind all of these together as one cc_library, or export them individually. I ask because looking at the related envoy change envoyproxy/envoy#1039, when you are depending in eds on api_cc, you bring unrelated proto libraries in. I see the benefit of having the single bind from envoy_cc_api to api_cc, but if bazel is meant to make dependencies explicit, I would think that exporting these individually might make more sense. Thoughts?
There was a problem hiding this comment.
I've switched to avoiding this. It was a convenience to avoid having to do bind for each of the libraries in the main Envoy repo, but it doesn't matter, we have to do something either side so it's fine to keep it fine grained, as you point out it's the Bazel way.
No description provided.