Merged
Conversation
htuch
reviewed
May 25, 2017
api/ratelimit.proto
Outdated
|
|
||
| option cc_generic_services = true; | ||
|
|
||
| package envoy.api.v1; |
Member
There was a problem hiding this comment.
We can chat more in a bit, but I think it would make sense to just put in the v2 namespace, rename to the new names. The old v1 API an continue to live in the existing location.
Member
Author
There was a problem hiding this comment.
forgot to tell you in person. But yeah this plan sounds good. Then we can migrate envoy and ratelimit, when I have gone through the process of making sure our internal clients can take the name change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@htuch Adding the ratelimit.proto file as is currently in the ratelimit repo. I am adding it under the
envoy.api.v1package given that we are changing the name to RLDS for v2.