Skip to content

Admin mutations must be issued as POST as of 1.7.#606

Merged
mattklein123 merged 6 commits intoenvoyproxy:masterfrom
jmarantz:admin-mutation-get-deprecation
Apr 5, 2018
Merged

Admin mutations must be issued as POST as of 1.7.#606
mattklein123 merged 6 commits intoenvoyproxy:masterfrom
jmarantz:admin-mutation-get-deprecation

Conversation

@jmarantz
Copy link
Copy Markdown
Contributor

@jmarantz jmarantz commented Apr 4, 2018

See also: envoyproxy/envoy#3001

Testing:

ci/run_envoy_docker.sh ci/do_ci.sh bazel.docs
cd generated/docs
python -m SimpleHTTPServer $PORT

Then navigated a browser to http://localhost:$PORT/intro/version_history.html and made sure all the new references worked, and formatting came out OK.

jmarantz added 2 commits April 4, 2018 17:27
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz jmarantz changed the title Admin mutation get deprecation message Admin mutations must be issued as POST as of 1.7. Apr 4, 2018
Signed-off-by: Joshua Marantz <jmarantz@google.com>
* tracing: the sampling decision is now delegated to the tracers, allowing the tracer to decide when and if
to use it. For example, if the :ref:`x-b3-sampled <config_http_conn_man_headers_x-b3-sampled>` header
is supplied with the client request, its value will override any sampling decision made by the Envoy proxy.
* admin-console mutations must be sent as POSTs, rather than GETs. Mutations include:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be alpha sorted.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also prefix with "admin: " like the other entry.

… around my changes.

Signed-off-by: Joshua Marantz <jmarantz@google.com>
* admin: added ``/stats/prometheus`` as an alternative endpoint for getting stats in prometheus format.
* cli: added --config-yaml flag to the Envoy binary. When set its value is interpreted as a yaml
representation of the bootstrap config and overrides --config-path.
* health check: added support for EDS delivered :ref:`endpoint health status
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this shouldn't be deleted?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ouch, sorry. I don't know what happened. Good catch. I did more sorting though, as the categories were sorted but not the entries within each category.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually I suspect that the format-fixer elided them...another block disappeared on me after running that. Or I could've fat-fingered it...I will investigate a little more.

…sorting swaps.

Signed-off-by: Joshua Marantz <jmarantz@google.com>
* admin: added ``/stats/prometheus`` as an alternative endpoint for getting stats in prometheus format.
* cli: added --config-yaml flag to the Envoy binary. When set its value is interpreted as a yaml
representation of the bootstrap config and overrides --config-path.
* health check: added support for EDS delivered :ref:`endpoint health status
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ouch, sorry. I don't know what happened. Good catch. I did more sorting though, as the categories were sorted but not the entries within each category.

1.7.0 (Pending)
===============

* Added :ref:`weighted round robin
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about this...it seems like "Added" is not a category; should this go into something like "load balancing" and put above "logging"?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a "bug." I already asked @htuch to fix this. Feel free to fix.

* admin: added :http:get:`/stats/prometheus` as an alternative endpoint for getting stats in prometheus format.
* admin: added :ref:`/runtime_modify endpoint <operations_admin_interface_runtime_modify>` to add or change runtime values
* admin: mutations must be sent as POSTs, rather than GETs. Mutations include:
:http:post:`/cpuprofiler`, :http:post:`/healthcheck/fail`, :http:post:`/healthcheck/ok`,
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT of using this style of live cross-reference here, which I found in fs_flags.rst?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, as long as it links up OK.

Signed-off-by: Joshua Marantz <jmarantz@google.com>
Copy link
Copy Markdown
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks.

@mattklein123 mattklein123 merged commit 4d846e2 into envoyproxy:master Apr 5, 2018
@jmarantz jmarantz deleted the admin-mutation-get-deprecation branch April 5, 2018 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants