docs: drop unnecessary field in DogStatsdSink message#545
Merged
htuch merged 3 commits intoenvoyproxy:masterfrom Mar 15, 2018
Merged
docs: drop unnecessary field in DogStatsdSink message#545htuch merged 3 commits intoenvoyproxy:masterfrom
htuch merged 3 commits intoenvoyproxy:masterfrom
Conversation
We can safely drop this field because users has ended up with initializing errors if they had specified this field. This field has never been used in envoy repo. Signed-off-by: Taiki Ono <taiki-ono@cookpad.com>
htuch
reviewed
Mar 14, 2018
|
|
||
| // The name of a cluster that is DogStatsD compliant TCP listener. If specified, | ||
| // Envoy will connect to this cluster to flush statistics. | ||
| string tcp_cluster_name = 2; |
Member
There was a problem hiding this comment.
Thanks. Can you add a comment like
data-plane-api/envoy/api/v2/cds.proto
Line 44 in f8cdf44
Member
There was a problem hiding this comment.
You should also add a reserved field for number 2, as describe here: https://github.com/envoyproxy/data-plane-api/blame/master/STYLE.md#L26
added 2 commits
March 15, 2018 03:38
Signed-off-by: Taiki Ono <taiki-ono@cookpad.com>
Signed-off-by: Taiki Ono <taiki-ono@cookpad.com>
htuch
approved these changes
Mar 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR of #325.
I mistook to add an unnecessary field here. What actually we need is just making
dog_statsd_specifieroneoffield, not addingtcp_cluster_namefield.We can safely drop this field because users has ended up with
initializing errors if they had specified this field.
This field has
never been used in envoy repo: https://github.com/envoyproxy/envoy/blob/7d03b231c7e8e086956096f6ca961f82c684ed0b/source/server/config/stats/dog_statsd.cc#L19-L23
Signed-off-by: Taiki Ono taiki-ono@cookpad.com