docs: clarify the x-forwarded-for documentation#463
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Feb 6, 2018
brian-pane:xff-docs/2503
Merged
docs: clarify the x-forwarded-for documentation#463mattklein123 merged 1 commit intoenvoyproxy:masterfrom brian-pane:xff-docs/2503
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
brian-pane:xff-docs/2503
Conversation
Signed-off-by: Brian Pane <bpane@pinterest.com>
mattklein123
approved these changes
Feb 6, 2018
Member
mattklein123
left a comment
There was a problem hiding this comment.
Very nice, thank you for this doc cleanup. @alyssawilk can you potentially read through this as well?
Contributor
|
I'm trusting @mattklein123 on correctness but assuming correctness I think this is a much more clear explanation of what's going on. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the discussion in #459, the XFF documentation doesn't match the implementation. This PR modifies the docs to try to describe more clearly the interaction between
use_remote_addressandX-Forwarded-For.Signed-off-by: Brian Pane bpane@pinterest.com