document the direct-response feature#436
Merged
mattklein123 merged 3 commits intoenvoyproxy:masterfrom Jan 26, 2018
brian-pane:direct-response-doc
Merged
document the direct-response feature#436mattklein123 merged 3 commits intoenvoyproxy:masterfrom brian-pane:direct-response-doc
mattklein123 merged 3 commits intoenvoyproxy:masterfrom
brian-pane:direct-response-doc
Conversation
envoyproxy/envoy issue: [2315](envoyproxy/envoy#2315) Signed-off-by: Brian Pane <bpane@pinterest.com>
Member
mattklein123
left a comment
There was a problem hiding this comment.
Thank you. Small nit, also can you see why doc build is failing?
| level. | ||
| * :ref:`Path <config_http_conn_man_route_table_route_path_redirect>`/:ref:`host | ||
| <config_http_conn_man_route_table_route_host_redirect>` redirection at the route level. | ||
| * :ref:`Direct HTTP responses <envoy_api_field_route.Route.direct_response_action>`, |
Contributor
Author
There was a problem hiding this comment.
That's intentional, to match the style of the rest of the items in the list.
Member
There was a problem hiding this comment.
It reads a little weird to me TBH, but not a big deal.
Contributor
Author
There was a problem hiding this comment.
I rephrased this item in the latest commit to this PR. Does the new wording work better?
…s work Signed-off-by: Brian Pane <bpane@pinterest.com>
Member
mattklein123
left a comment
There was a problem hiding this comment.
LGTM, small optional nit/suggestion.
| can specify the response body inline or specify the pathname of a file containing the | ||
| body. If the Route configuration specifies a file pathname, Envoy will read the file | ||
| upon configuration load and cache the contents. Regardless of whether the body is | ||
| provided inline or in a file, the body length must be less than or equal to 4KB. |
Member
There was a problem hiding this comment.
nit: I might put the 4KB limitation inside an explicit .. attention:: markup with a small explanation of why.
Signed-off-by: Brian Pane <bpane@pinterest.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
envoyproxy/envoy issue: 2315
Signed-off-by: Brian Pane bpane@pinterest.com