admin: document /runtime endpoint#414
Merged
mattklein123 merged 4 commits intoenvoyproxy:masterfrom Jan 16, 2018
rodaine:admin-runtime-endpoint
Merged
admin: document /runtime endpoint#414mattklein123 merged 4 commits intoenvoyproxy:masterfrom rodaine:admin-runtime-endpoint
mattklein123 merged 4 commits intoenvoyproxy:masterfrom
rodaine:admin-runtime-endpoint
Conversation
Signed-off-by: Chris Roche <croche@lyft.com>
htuch
reviewed
Jan 12, 2018
docs/root/operations/admin.rst
Outdated
|
|
||
| .. http:get:: /runtime | ||
|
|
||
| Outputs all runtime values on demand. See :ref:`here <config_runtime_v1>` for more information on |
Member
There was a problem hiding this comment.
Maybe make explicit this is human readable text format (to contrast with JSON below).
Member
mattklein123
left a comment
There was a problem hiding this comment.
LGTM other than @htuch comments.
added 2 commits
January 12, 2018 09:36
Signed-off-by: Chris Roche <croche@lyft.com>
docs/root/operations/admin.rst
Outdated
| .. http:get:: /runtime | ||
|
|
||
| Outputs all runtime values on demand in a human-readable format. See | ||
| :ref:`here <config_runtime_v1>` for more information on how these values are configured |
Member
There was a problem hiding this comment.
Please link to this page: https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/runtime, otherwise looks great!
htuch
previously approved these changes
Jan 16, 2018
Signed-off-by: Chris Roche <croche@lyft.com>
mattklein123
approved these changes
Jan 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents the
/runtimeadmin endpoint added for read-only access to the current runtime values.Related: envoyproxy/envoy#2353