Merged
Conversation
Signed-off-by: Rama <ramaraochavali@gmail.com>
Signed-off-by: Rama <ramaraochavali@gmail.com>
Member
mattklein123
left a comment
There was a problem hiding this comment.
LGTM, thanks! Can you possibly modify this doc: https://github.com/envoyproxy/data-plane-api/blob/master/api/stats.proto#L21 to list out the options kind of like we do for filter? https://github.com/envoyproxy/data-plane-api/blob/master/api/lds.proto#L112
Thank you!
Signed-off-by: Rama <ramaraochavali@gmail.com>
Contributor
Author
|
@mattklein123 @htuch updated the docs with review comments. |
Signed-off-by: Rama <ramaraochavali@gmail.com>
Signed-off-by: Rama <ramaraochavali@gmail.com>
mattklein123
approved these changes
Jan 12, 2018
Member
mattklein123
left a comment
There was a problem hiding this comment.
Nice, thanks. LGTM. Will defer to @htuch for merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doc PR for Envoy implementation PR envoyproxy/envoy#2323