Docs: add notice related to lua and exported symbols#405
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Jan 17, 2018
Merged
Docs: add notice related to lua and exported symbols#405mattklein123 merged 1 commit intoenvoyproxy:masterfrom
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
Conversation
95868e2 to
27d7463
Compare
mattklein123
reviewed
Jan 9, 2018
Member
mattklein123
left a comment
There was a problem hiding this comment.
LGTM, small grammar nit. Also need to fix "over eager spaces" :)
| .. attention:: | ||
|
|
||
| By default envoy is built without exporting symbols that you may need when interacting with | ||
| lua modules installed as shared objects. If may need to build envoy with support for exported symbols. |
htuch
reviewed
Jan 10, 2018
|
|
||
| .. attention:: | ||
|
|
||
| By default envoy is built without exporting symbols that you may need when interacting with |
Member
There was a problem hiding this comment.
Nit: s/envoy/Envoy/ in various palces, s/lua/Lua/, s/bazel/Bazel/ below as well.
ae86372 to
abddab6
Compare
Signed-off-by: Nicholas J <nicholas.a.johns5@gmail.com>
29f3e33 to
44ab76c
Compare
Contributor
Author
|
Updates made 👍 |
mattklein123
approved these changes
Jan 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added a notice to the lua filter related to how it's built and linked and that a user wishing to load modules installed with luarocks would need to build envoy with exported symbols.
Signed-off-by: Nicholas J nicholas.a.johns5@gmail.com