Update RDS hash policy docs#194
Merged
mattklein123 merged 3 commits intoenvoyproxy:masterfrom Oct 16, 2017
Merged
Conversation
8df09fb to
8e8279c
Compare
Signed-off-by: Alex Konradi <akonradi@google.com>
Signed-off-by: Alex Konradi <akonradi@google.com>
8e8279c to
b068df6
Compare
htuch
reviewed
Oct 16, 2017
api/rds.proto
Outdated
| // endpoint. The cookie is generated by hashing the source and | ||
| // destination ports and addresses so that multiple independent HTTP2 | ||
| // streams will independently receive the same cookie, even if they | ||
| // arrive at the envoy simultaneously. |
api/rds.proto
Outdated
| // endpoint. | ||
| // endpoint. The cookie is generated by hashing the source and | ||
| // destination ports and addresses so that multiple independent HTTP2 | ||
| // streams will independently receive the same cookie, even if they |
Member
There was a problem hiding this comment.
streams on the same connection. If you had a "smart" gRPC client that initiated multiple connections (and somehow had a cookie store, which gRPC clients don't tend to), there might still be a race.
Signed-off-by: Alex Konradi <akonradi@google.com>
htuch
approved these changes
Oct 16, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document changes introduced by envoyproxy/envoy#1756 (multiple hash policies) and envoyproxy/envoy#1766 (cookie hashing).