controller: make extProc imagePullPolicy configurable#729
Merged
mathetake merged 3 commits intoenvoyproxy:mainfrom Jun 20, 2025
Merged
controller: make extProc imagePullPolicy configurable#729mathetake merged 3 commits intoenvoyproxy:mainfrom
mathetake merged 3 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Jeong Woon Choi <choijeongwoon@gmail.com>
23818eb to
af54797
Compare
mathetake
reviewed
Jun 19, 2025
|
|
||
| extProc: | ||
| repository: docker.io/envoyproxy/ai-gateway-extproc | ||
| pullPolicy: IfNotPresent |
Member
There was a problem hiding this comment.
Suggested change
| pullPolicy: IfNotPresent | |
| imagePullPolicy: IfNotPresent |
Contributor
Author
There was a problem hiding this comment.
I've updated the names. Nevertheless there is a little inconsistency between controller image settings and extProc image settings.
# -- Deployment configs --
image:
repository: docker.io/envoyproxy/ai-gateway-controller
pullPolicy: IfNotPresent
# Overrides the image tag whose default is the chart appVersion.
tag: ""
Member
There was a problem hiding this comment.
oh that's what i didn't notice. could you go ahead the controller one as well? I would prefer imagePullPolicy
Contributor
Author
There was a problem hiding this comment.
I think I have 2 options
extProc:
image:
repository: docker.io/envoyproxy/ai-gateway-extproc
# Overrides the image tag whose default is the chart appVersion.
tag: ""
imagePullPolicy: IfNotPresent
controller:
# .......
image:
repository: docker.io/envoyproxy/ai-gateway-controller
# Overrides the image tag whose default is the chart appVersion.
tag: ""
imagePullPolicy: IfNotPresentor
extProc:
repository: docker.io/envoyproxy/ai-gateway-extproc
# Overrides the image tag whose default is the chart appVersion.
tag: ""
imagePullPolicy: IfNotPresent
controller:
# .......
image:
repository: docker.io/envoyproxy/ai-gateway-controller
# Overrides the image tag whose default is the chart appVersion.
tag: ""
imagePullPolicy: IfNotPresentI think both are valid. No preference. So maybe your opinions on this?
Signed-off-by: Jeong Woon Choi <choijeongwoon@gmail.com>
Signed-off-by: Jeong Woon Choi <choijeongwoon@gmail.com>
mathetake
approved these changes
Jun 20, 2025
Member
mathetake
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message
Allows operators to set the imagePullPolicy for the external processor, just like the existing controller setting (controller.image.pullPolicy).
Related Issues/PRs (if applicable)
Special notes for reviewers (if applicable)
I'm not sure if I have to consider this pr: #699