feat: move Backends back to RouteRule#633
Merged
mathetake merged 2 commits intoenvoyproxy:mainfrom May 22, 2025
Merged
Conversation
51fa137 to
efe7d34
Compare
Signed-off-by: kerthcet <kerthcet@gmail.com>
fd1e824 to
1b730b2
Compare
Contributor
Author
|
/assign @mathetake as discussed offline. |
mathetake
reviewed
May 22, 2025
internal/extproc/server.go
Outdated
Comment on lines
+88
to
+91
| for _, r := range config.Rules { | ||
| for _, backend := range r.Backends { | ||
| b := backend | ||
| var h backendauth.Handler |
Member
There was a problem hiding this comment.
can you merge this for-loop over r.Backends to the for-loop above at l75? we do looping over config.Rules twice here
Contributor
Author
There was a problem hiding this comment.
good catch. Addressed. PTAL.
Signed-off-by: kerthcet <kerthcet@gmail.com>
mathetake
approved these changes
May 22, 2025
Member
|
Thank you! @kerthcet |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message
The backends and headers in filter config are M:N, with #599, we swapped out the backend from the config.rules, leading to the lost mapping relationship between them. With this PR, we'll move the backends back to the config.rules which is more straightforward.
Related Issues/PRs (if applicable)
Related PR: #620, #599
Special notes for reviewers (if applicable)
None