Conversation
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Member
Author
kerthcet
reviewed
May 12, 2025
|
|
||
| // Timeouts defines the timeouts that can be configured for an HTTP request. | ||
| // | ||
| // Deprecated: Use the `BackendTrafficPolicySpec` for a backend-specific timeout configuration, or |
Contributor
There was a problem hiding this comment.
Maybe worth to add explanations in AIGatewayRouteRule.Timeouts about the priorities between different timeouts.
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
yuzisun
approved these changes
May 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message
This deprecates the AIServiceBackend.Timeouts configuration that has started working not well with the refactored use of HTTPRoute since #599. Instead, this adds
timeoutsinto AIGatewayRouteRule to matche the one of HTTPRoute in GWAPI.