Conversation
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Member
Author
|
PTAL @arkodg |
arkodg
reviewed
Apr 18, 2025
|
|
||
| // AIGatewayRouteSpec details the AIGatewayRoute configuration. | ||
| // | ||
| // +kubebuilder:validation:XValidation:rule="!has(self.parentRefs) || !has(self.targetRefs) || size(self.targetRefs) == 0", message="targetRefs is deprecated, use parentRefs only" |
There was a problem hiding this comment.
this will reject previous config, is that the goal ?
Member
Author
There was a problem hiding this comment.
No this won’t reject existing ones as they don’t have parentRefs set hence this is always true
arkodg
reviewed
Apr 18, 2025
| // Deprecated: use the ParentRefs field instead. This field will be dropped in Envoy AI Gateway v0.3.0. | ||
| TargetRefs []gwapiv1a2.LocalPolicyTargetReferenceWithSectionName `json:"targetRefs,omitempty"` | ||
| // ParentRefs are the names of the Gateway resources this AIGatewayRoute is being attached to. | ||
| // Cross namespace references are not supported. In other words, the Gateway resources must be in the |
There was a problem hiding this comment.
can this be relaxed in the future / follow up PR ?
its very common for the Gateway and Route to live in different ns
Member
Author
|
ping someone could you approve @envoyproxy/ai-gateway-maintainers |
Member
Author
|
this needs a rebase after v0.2 |
Member
Author
|
will redo later |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message
This will mark
targetRefsfield of AIGatewayRoute as deprecated in favor of parentRefs, which is more idiomatic way of "attaching" routes to Gateways.The field will be removed in the one version after the next release, which is v0.3.0.
Related Issues/PRs (if applicable)
Closes #550