Delete simulator after plugin_test_ios (#136265)

vashworth · web-flow · commit e8bd5a327158 · 2023-10-10T17:22:07.000Z
Remove simulator once it's no longer needed for test `plugin_test_ios` . Fixes flutter/flutter#136224
diff --git a/dev/devicelab/lib/tasks/plugin_tests.dart b/dev/devicelab/lib/tasks/plugin_tests.dart
@@ -263,17 +263,23 @@ public class $pluginClass: NSObject, FlutterPlugin {
           throw TaskResult.failure('Platform unit tests failed');
         }
       case 'ios':
-        await testWithNewIOSSimulator('TestNativeUnitTests', (String deviceId) async {
-          if (!await runXcodeTests(
-            platformDirectory: path.join(rootPath, 'ios'),
-            destination: 'id=$deviceId',
-            configuration: 'Debug',
-            testName: 'native_plugin_unit_tests_ios',
-            skipCodesign: true,
-          )) {
-            throw TaskResult.failure('Platform unit tests failed');
-          }
-        });
+        String? simulatorDeviceId;
+        try {
+          await testWithNewIOSSimulator('TestNativeUnitTests', (String deviceId) async {
+            simulatorDeviceId = deviceId;
+            if (!await runXcodeTests(
+              platformDirectory: path.join(rootPath, 'ios'),
+              destination: 'id=$deviceId',
+              configuration: 'Debug',
+              testName: 'native_plugin_unit_tests_ios',
+              skipCodesign: true,
+            )) {
+              throw TaskResult.failure('Platform unit tests failed');
+            }
+          });
+        } finally {
+          await removeIOSimulator(simulatorDeviceId);
+        }
       case 'linux':
         if (await exec(
           path.join(rootPath, 'build', 'linux', 'x64', 'release', 'plugins', 'plugintest', 'plugintest_test'),
