Ensure to pass dill file after VM options for gen_snapshot (flutter#7839)

mkustermann · web-flow · commit ecbaea10a4f2 · 2019-02-15T15:17:54.000+01:00
diff --git a/lib/snapshot/BUILD.gn b/lib/snapshot/BUILD.gn
@@ -60,17 +60,15 @@ compiled_action("generate_snapshot_bin") {
     "--isolate_snapshot_data=" + rebase_path(isolate_snapshot_data),
     "--isolate_snapshot_instructions=" +
         rebase_path(isolate_snapshot_instructions),
-    rebase_path(platform_kernel),
   ]
 
   if (is_debug) {
     args += [
       "--enable_asserts",
-      "--enable_type_checks",
-      "--error_on_bad_type",
-      "--error_on_bad_override",
     ]
   }
+
+  args += [rebase_path(platform_kernel)]
 }
 
 # Generates an assembly file defining a given symbol with the bytes from a

Original file line number	Diff line number	Diff line change
`@@ -60,17 +60,15 @@ compiled_action("generate_snapshot_bin") {`
`60`	`60`	`"--isolate_snapshot_data=" + rebase_path(isolate_snapshot_data),`
`61`	`61`	`"--isolate_snapshot_instructions=" +`
`62`	`62`	`rebase_path(isolate_snapshot_instructions),`
`63`		`- rebase_path(platform_kernel),`
`64`	`63`	`]`
`65`	`64`
`66`	`65`	`if (is_debug) {`
`67`	`66`	`args += [`
`68`	`67`	`"--enable_asserts",`
`69`		`- "--enable_type_checks",`
`70`		`- "--error_on_bad_type",`
`71`		`- "--error_on_bad_override",`
`72`	`68`	`]`
`73`	`69`	`}`
	`70`	`+`
	`71`	`+ args += [rebase_path(platform_kernel)]`
`74`	`72`	`}`
`75`	`73`
`76`	`74`	`# Generates an assembly file defining a given symbol with the bytes from a`