Provide a matrix inverse shim for GLES 2.0. (flutter#50545)

johnoneil · web-flow · commit df0dc1fc06ca · 2024-02-15T16:32:03.000Z
This PR addresses [ Issue flutter#141829](flutter#141829). We saw a shader compilation error after updating `flutter/impeller` due to the lack of a matrix `inverse` implementation on GLSL 1.0 used on GLSL 2.0. This change provides one (for the current used case which is only for `mat3` support. I think this change needs some discussion as gating the change on GLSL < 1.4 would be more effective. Also my knowledge of correctly managing these `.glsl` based shaders is still superficial. - [x ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x ] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [x ] I listed at least one issue that this PR fixes in the description above. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
diff --git a/impeller/compiler/shader_lib/impeller/gradient.glsl b/impeller/compiler/shader_lib/impeller/gradient.glsl
@@ -6,13 +6,14 @@
 #define GRADIENT_GLSL_
 
 #include <impeller/texture.glsl>
+#include <impeller/transform.glsl>
 
 mat3 IPMapToUnitX(vec2 p0, vec2 p1) {
   // Returns a matrix that maps [p0, p1] to [(0, 0), (1, 0)]. Results are
   // undefined if p0 = p1.
   return mat3(0.0, -1.0, 0.0, 1.0, 0.0, 0.0, 0.0, 0.0, 1.0) *
-         inverse(mat3(p1.y - p0.y, p0.x - p1.x, 0.0, p1.x - p0.x, p1.y - p0.y,
-                      0.0, p0.x, p0.y, 1.0));
+         IPMat3Inverse(mat3(p1.y - p0.y, p0.x - p1.x, 0.0, p1.x - p0.x,
+                            p1.y - p0.y, 0.0, p0.x, p0.y, 1.0));
 }
 
 /// Compute the t value for a conical gradient at point `p` between the 2
diff --git a/impeller/compiler/shader_lib/impeller/transform.glsl b/impeller/compiler/shader_lib/impeller/transform.glsl
@@ -26,4 +26,33 @@ vec4 IPPositionForGlyphPosition(mat4 mvp,
               unit_position.y * destination_size.y, 0.0, 1.0);
 }
 
-#endif
+#ifdef IMPELLER_TARGET_OPENGLES
+
+// Shim matrix `inverse` for versions that lack it.
+// TODO: This could be gated on GLSL < 1.4.
+mat3 IPMat3Inverse(mat3 m) {
+  float a00 = m[0][0], a01 = m[0][1], a02 = m[0][2];
+  float a10 = m[1][0], a11 = m[1][1], a12 = m[1][2];
+  float a20 = m[2][0], a21 = m[2][1], a22 = m[2][2];
+
+  float b01 = a22 * a11 - a12 * a21;
+  float b11 = -a22 * a10 + a12 * a20;
+  float b21 = a21 * a10 - a11 * a20;
+
+  float det = a00 * b01 + a01 * b11 + a02 * b21;
+
+  return mat3(b01, (-a22 * a01 + a02 * a21), (a12 * a01 - a02 * a11), b11,
+              (a22 * a00 - a02 * a20), (-a12 * a00 + a02 * a10), b21,
+              (-a21 * a00 + a01 * a20), (a11 * a00 - a01 * a10)) /
+         det;
+}
+
+#else  // IMPELLER_TARGET_OPENGLES
+
+mat3 IPMat3Inverse(mat3 m) {
+  return inverse(m);
+}
+
+#endif  // IMPELLER_TARGET_OPENGLES
+
+#endif  // TRANSFORM_GLSL_
