Fix race condition in Unobstructed Platform View Scenario tests (flutter#48096)

vashworth · web-flow · commit 13cdf933d641 · 2023-11-16T19:02:57.000Z
Fixes race situation where `_onPlatformMessage` is triggered before the first frame, essentially skipping the first frame. Fixes flutter#138193. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
diff --git a/testing/scenario_app/lib/src/platform_view.dart b/testing/scenario_app/lib/src/platform_view.dart
@@ -422,7 +422,6 @@ class MultiPlatformViewBackgroundForegroundScenario extends Scenario
     required this.secondId,
   }) {
     _nextFrame = _firstFrame;
-    channelBuffers.setListener('flutter/lifecycle', _onPlatformMessage);
   }
 
   /// The platform view identifier to use for the first platform view.
@@ -438,7 +437,13 @@ class MultiPlatformViewBackgroundForegroundScenario extends Scenario
     _nextFrame();
   }
 
+  bool _firstFrameBegan = false;
+
   void _firstFrame() {
+    if (!_firstFrameBegan) {
+      channelBuffers.setListener('flutter/lifecycle', _onPlatformMessage);
+    }
+    _firstFrameBegan = true;
     final SceneBuilder builder = SceneBuilder();
 
     builder.pushOffset(50, 600);
