Skip to content

Enable select2 #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
msquare merged 1 commit into from
Oct 21, 2020
Merged

Enable select2 #765

msquare merged 1 commit into from
Oct 21, 2020

Conversation

@MyIgel
Copy link
Member

@MyIgel MyIgel commented Oct 20, 2020

We could also only use select2 on selects with more than ~5 elements but that would be more confusing

$('select').each(function (_, select) {
    if (select.length > 5) {
        $(select).select2();
    }
})

resolves #235 (selection users should be possible by some fancy javascript search)
fixes #554 (Messages: User search function or alphabetical order?)

@MyIgel MyIgel added Type: Feature An idea for a new feature hacktoberfest-accepted Created during Hacktoberfest labels Oct 20, 2020
@msquare msquare merged commit 00f812f into engelsystem:master Oct 21, 2020
@MyIgel MyIgel deleted the select2 branch October 22, 2020 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

hacktoberfest-accepted Created during Hacktoberfest Type: Feature An idea for a new feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Messages: User search function or alphabetical order? selection users should be possible by some fancy javascript search

2 participants

@MyIgel @msquare