Skip to content

Conversation

@MyIgel
Copy link
Member

@MyIgel MyIgel commented Apr 6, 2020

Mainly the same functionality but some minor detail changes (add button in title, order by and show latest change, no author highjacking)

Other changes:

  • Refactored user notifications (save to session and display) to be flexible
  • Refactored logger to include the currently logged in user (if any)
  • Show 404 on ModelNotFoundException to allow Model::findOrFail($id)
  • The dd() and dump() functions can now be used in template files
  • Sadly the "smilies" got lost but hey, there is UTF-8 and maybe we can add some more proper handling for it later (like replacing :tada: with 🎉 if we support markdown instead of / in addition to html)
  • Removed LegacyUrlGenerator (broke a while ago in a merge commit...)
  • Redirector now uses URLs instead of relative paths (using the optionally configured application base url)

@MyIgel MyIgel added the Type: Refactor Make the code better. label Apr 6, 2020
@MyIgel MyIgel added this to the Complete first rewrite milestone Apr 6, 2020
@MyIgel MyIgel requested a review from msquare April 24, 2020 18:18
@msquare msquare merged commit 795a063 into engelsystem:master Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Refactor Make the code better.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants