fix: remove "apply" from enablements whitelist#475
Conversation
ljharb
left a comment
There was a problem hiding this comment.
The only thing I can think of is that a prior stack trace incorrectly pointed to tape (the user's presumed test runner) as the cause, which means that this PR would again break them, at which point we could triage the stack trace to find the proper cause of the error.
warner
left a comment
There was a problem hiding this comment.
I can't remember how tape interacted with this. I do vaguely remember differences between tape version 4 and version 5, and maybe we were unable to use version 5 because it had problems that 4 did not.
We're using AVA on agoric-sdk now, not tape, so that won't be a source of compatibility data anymore.
I'd say remove it and then wait for something else to indicate a compatibility problem.
|
tape 5's breaking change was respecting a promise returned from the test callback; it shouldn't be possible for v4 vs v5 to have affected this. (sorry to hear you're no longer using tape :-( ) |
Fixes #474
Removes
Function.prototype.applyfrom the enablements whitelist, of properties that need the override mistake fixed. This particular entry said it was becausetapebroke. But @ljharb , the maintainer of tape, said that it should not have a problem withapply. After removing it, our existing tests work just fine. But (question for reviewers) do any of them use tape in a way that would detect a remaining problem if there is one?