fix(immutable-arraybuffer): capture structuredClone early#2853
Merged
Conversation
kriskowal
approved these changes
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #XXXX
Refs: #2785
Description
The Immutable ArrayBuffer shim, on non-Hermes, relies on the existence of either a global
structuredCloneorArray.prototype.transfer. However, I forgot to capture early the globalstructuredCloneinto a module-local one, and to then use that repeatedly. MetaMask scuttling deleted the globalstructuredClone, running headlong into my mistake on platforms (Node 18 and Node 20) that do not also haveArray.prototype.transfer.This PR fixes that mistake, capturing
structuredCloneearly, and then using the resulting module-local one.Security Considerations
The bug this PR fixes was a security hazard.
Scaling Considerations
none
Documentation Considerations
none
Testing Considerations
In theory, we should add scuttling as an orthogonal dimension of our platform testing matrix. However that is rather expensive for minor benefit.
Compatibility Considerations
The bug created compat problems that this PR fixes.
Upgrade Considerations
none