fix(ses): make test insensitive to an irrelevant env var#2403
Merged
Conversation
3853cc7 to
047e114
Compare
kriskowal
approved these changes
Aug 21, 2024
047e114 to
f1303f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #XXXX
Refs: #2383
Description
Of the various property override tests, the ones testing the default
'moderate'setting were callinglockdownwithout anoverrideTamingoption, counting on it to default to'moderate'. However, if run locally in an environment where the environment variableLOCKDOWN_OVERRIDE_TAMINGwas set to something else, the test would pointlessly misbehave.This PR merely sets the option explicitly for those cases, so the tests for the
'moderate'case are as insensitive to environment variables as the tests for the other cases.Security Considerations
none
Scaling Considerations
none
Documentation Considerations
none
Testing Considerations
The point. The code before this PR would always work correctly under CI. But the test may pointless fail locally depending on the developers environment variable settings.
Compatibility Considerations
none
Upgrade Considerations
none