fix(patterns): pass type parameter from interface guard to payload#1771
Merged
fix(patterns): pass type parameter from interface guard to payload#1771
Conversation
This was referenced Sep 16, 2023
michaelfig
approved these changes
Sep 16, 2023
Member
michaelfig
left a comment
There was a problem hiding this comment.
Straightforward! Sorry for the omission.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous endo release added
getInterfaceGuardPayloadso that agoric-sdk could start to use it, rather than accessing the fields of an interface guard directly. This paves the way for #1712 . However, because the type ofgetInterfaceGuardPayloaddid not propagate the type parameter from the guard argument to the returned payload, the Agoric/agoric-sdk#8339 attempt to switch to it causes type errors due to the loss of this type information.