What is the Problem Being Solved?
Windows compatibility
introduces a couple scripts which run fine in CI (ubuntu-latest) and locally (macOS), but may not on Windows
|
"build:hermes": "SES_BUILD_TYPE=hermes node scripts/bundle.js", |
runs on my Win11 machine #2334 (comment) but may not for others
|
"test:hermes": "./scripts/hermes.sh", |
doesn't run on Windows #2334 (comment)
it could be a good idea to support Windows contributors running these locally
including those setup to run React Native on Windows
Description of the Design
1 build:hermes util.parseArgs #2334 (comment)
2 test:hermes unsure how to run this on Windows, @boneskull may have an idea
Security Considerations
Scaling Considerations
Test Plan
consider running windows-latest in CI (Windows Server 2022)
Compatibility Considerations
Upgrade Considerations
What is the Problem Being Solved?
Windows compatibility
introduces a couple scripts which run fine in CI (ubuntu-latest) and locally (macOS), but may not on Windows
endo/packages/ses/package.json
Line 73 in 13aa1af
runs on my Win11 machine #2334 (comment) but may not for others
endo/packages/ses/package.json
Line 85 in 13aa1af
doesn't run on Windows #2334 (comment)
it could be a good idea to support Windows contributors running these locally
including those setup to run React Native on Windows
Description of the Design
1
build:hermesutil.parseArgs #2334 (comment)2
test:hermesunsure how to run this on Windows, @boneskull may have an ideaSecurity Considerations
Scaling Considerations
Test Plan
consider running windows-latest in CI (Windows Server 2022)
Compatibility Considerations
Upgrade Considerations