Open
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
|
Play this branch at https://play.threadbare.game/branches/endlessm/wjt/remove-interact-area-tscn. (This launches the game from the start, not directly at the change(s) in this pull request.) |
This scene was previously an Area2D with interact_area.gd attached. The advantage of doing this is that the scene has its collision_layer and collision_mask configured appropriately. However, interact_area.gd already partially handled this configuration automatically, toggling the INTERACTABLE bit depending on its disabled property. In other scenes in the game we had a mixture of instances of the scene, and bare Area2D nodes with interact_area.gd attached. Make interact_area.gd fully manage the collision_layer and collision_mask. Remove the logic to warn if they are incorrect, since it is now not possible to configure them incorrectly. Eliminate the scene. Simplify the folder structure slightly.
07b4287 to
fd9f853
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This scene was previously an Area2D with interact_area.gd attached. The
advantage of doing this is that the scene has its collision_layer and
collision_mask configured appropriately.
However, interact_area.gd already partially handled this configuration
automatically, toggling the INTERACTABLE bit depending on its disabled
property. In other scenes in the game we had a mixture of instances of
the scene, and bare Area2D nodes with interact_area.gd attached.
Make interact_area.gd fully manage the collision_layer and collision_mask.
Remove the logic to warn if they are incorrect, since it is now not
possible to configure them incorrectly. Eliminate the scene. Simplify
the folder structure slightly.