Closed
Conversation
To get this working I rebuilt the 3 block code programs with exactly the same blocks as before. I then added a CollisionPolygon2D to the SimpleCharacter. This is because in the old plugin version a 100×100 square CollisionShape2D was unconditionally added; whereas in the new version this is only added if the SimpleCharacter's texture property is set. But the texture property is not set. We could instead set the texture and drop the Sprite2D2 child. However it's not as trivial as setting the texture property because the sprite is the wrong size and is scaled down to 0.321 its full size by the Sprite2D2. So, add a CollisionPolygon2D, and adjust the position of the dead zone accordingly.
43f6a83 to
c9ba5a6
Compare
Member
Author
|
We came to the conclusion in discussion today that we should instead remove this demo because the new one from godotcon is a better demo of how to make a runner. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To get this working I rebuilt the 3 block code programs with exactly the same blocks as before.
I then added a CollisionPolygon2D to the SimpleCharacter. This is because in the old plugin version a 100×100 square CollisionShape2D was unconditionally added; whereas in the new version this is only added if the SimpleCharacter's texture property is set. But the texture property is not set.
We could instead set the texture and drop the Sprite2D2 child. However it's not as trivial as setting the texture property because the sprite is the wrong size and is scaled down to 0.321 its full size by the Sprite2D2.
So, add a CollisionPolygon2D, and adjust the position of the dead zone accordingly.