Set Godot 4.3 as minimum supported version#346
Merged
Conversation
This will make future diffs that add and remove engine versions more legible.
Godot 4.3 has been available for 4 months and it seems unlikely that anyone will have a pressing need to add blocks to a Godot 4.2 project. Although we have been running unit tests against 4.2 in CI, those do not cover the full functionality of the plugin. To the best of my knowledge, no-one is regularly testing the plugin interactively against Godot 4.2. Set the minimum version in the asset library template. Drop 4.2 from the CI test matrix.
Now that Godot 4.3 is the minimum supported version, we can use this new method to merge two dictionaries a little more tersely.
This backs out commit 99e2dc1. We now require Godot 4.3.
809e24c to
2684d95
Compare
manuq
requested changes
Dec 18, 2024
Contributor
manuq
left a comment
There was a problem hiding this comment.
Could you also address the "Polyfill of Node.is_part_of_edited_scene(), available to GDScript in Godot 4.3+." in addons/block_code/ui/util.gd ?
We now require Godot 4.3, which introduces this method.
Member
Author
|
Done |
manuq
approved these changes
Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Godot 4.3 has been available for 4 months and it seems unlikely that anyone will have a pressing need to add blocks to a Godot 4.2 project.
Although we have been running unit tests against 4.2 in CI, those do not cover the full functionality of the plugin. To the best of my knowledge, no-one is regularly testing the plugin interactively against Godot 4.2.
Set the minimum version in the asset library template. Drop 4.2 from the CI test matrix. Remove some workarounds for 4.2 compatibility.