Merged
Conversation
dbnicholson
requested changes
Nov 4, 2024
gut's cmdline script accepts a number of command-line arguments. It appears that the Godot engine removes most of its own options from the argument list available to user code, but it leaves any `--script FOO` or `-s FOO` arguments in place. gut 9.2.1 understands both the `--script` and `-s` forms, but gut 9.3.0 only understands the `-s` form and raises an error if the `--script` form is used. bitwes/Gut#667
7effa6e to
31b09aa
Compare
dbnicholson
approved these changes
Nov 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My original hope was that a newer Gut would avoid 4.4.0-dev3 crashing in a branch where I tried to add that version to the CI matrix. On closer inspection it's actually crashing at the
--importstep, and this doesn't help at all, but now I've done this update (which mainly involved working around a command line argument handling regression) I thought I may as well separate out these patches.