Merged
Conversation
99ac35e to
ce261bf
Compare
Add an option for playing the animation and waiting until it's done. The previous behavior is now another option "play in the background". For editing these block definition options in the Inspector, the class name is back to OptionData.
ce261bf to
0f8d008
Compare
dylanmccall
approved these changes
Oct 10, 2024
Contributor
dylanmccall
left a comment
There was a problem hiding this comment.
I fixed a small issue where wait_mode was wrapped in the wrong kind of braces, and removed a change adding class_name OptionData to option_data.gd. I do think we should do that, but I don't recall why we don't at the moment and I think we should change it in a more purposeful place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an option for playing the animation and waiting until it's done. The previous behavior is now another option "play in the background".
For editing these block definition options in the Inspector, the class name is back to OptionData.