ParameterInput: Ignore mouse events when not visible#236
Merged
dbnicholson merged 2 commits intomainfrom Sep 27, 2024
Merged
Conversation
cb6388c to
80526a2
Compare
832060d to
966f5af
Compare
dbnicholson
reviewed
Sep 26, 2024
addons/block_code/ui/blocks/utilities/drag_drop_area/drag_drop_area.gd
Outdated
Show resolved
Hide resolved
966f5af to
5606e74
Compare
Instead of emitting mouse_down and mouse_up signals, change DragDropArea to detect drag gestures by monitoring mouse input events.
Instead of using ParameterInput's own input events, add a DragDropArea for each input component. This allows us to use _gui_input events so events are correctly filtered based on z order and visibility.
5606e74 to
eece502
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using only _input to process events, use _gui_input to watch for mouse button events that are understood to be for an input control, but use _input to watch for mouse movement events which may occur outside of the control.
To work within the rules of Godot's GUI event system, we need to do this in a control which is a child of each input control. This is achieved using draggable_overlay.tscn.