Merged
Conversation
14c6533 to
f3d0b7b
Compare
dbnicholson
requested changes
Sep 26, 2024
Member
dbnicholson
left a comment
There was a problem hiding this comment.
Nice! I was wondering how those were lost.
Prior to commit 7a6fe13, instantiate_block() would set the new Block's tooltip_text property to the BlockDefinition's description. Since that commit, we just set a definition property on the Block to the BlockDefinition. Implement Control._get_tooltip(), returning BlockDefinition.definition, which restores tooltips to blocks. https://phabricator.endlessm.com/T35645
f3d0b7b to
b9fa778
Compare
dbnicholson
approved these changes
Sep 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to commit 7a6fe13, instantiate_block() would set the new Block's tooltip_text property to the BlockDefinition's description.
Since that commit, we just set a definition property on the Block to the BlockDefinition.
Implement Control._get_tooltip(), returning BlockDefinition.definition, which restores tooltips to blocks.
https://phabricator.endlessm.com/T35645