ParameterInput: Detect click & drag gestures#233
Merged
dylanmccall merged 1 commit intomainfrom Sep 26, 2024
Merged
Conversation
Contributor
Author
|
Here's a recording showing this in action: Screencast.From.2024-09-25.15-38-51.webmNote that this changes our option widgets to open when the mouse is released, instead of when the mouse is pressed. The Godot editor is a little inconsistent on which behaviour it uses, but I think it works better this way (and it's necessary for this feature to work). |
manuq
approved these changes
Sep 25, 2024
Contributor
manuq
left a comment
There was a problem hiding this comment.
This makes the dragging work much better while editing. A nice touch.
addons/block_code/ui/blocks/utilities/parameter_input/parameter_input.gd
Outdated
Show resolved
Hide resolved
8cc05ba to
19111ca
Compare
If the user clicks and drags inside ParameterInput, start dragging the parent block. This makes it easier to manipulate blocks which contain a large number of parameter input widgets.
19111ca to
6daa3ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the user clicks and drags inside ParameterInput, start dragging the parent block. This makes it easier to manipulate blocks which contain a large number of parameter input widgets.