Conversation
65d0240 to
b950051
Compare
|
I think this is reasonable, particularly since the flatpak has been updated to 4.3, and that's the primary way most of our developers use Godot. Did you open our project in 4.3? When I've done this before, it's reimported assets. Can you update the tests to use 4.3? Actually, we should probably run those with a matrix of several older Godot versions since we can't expect users to be update Godot. |
Godot 4.3 adds `disable_embedded_bitmaps=true` in font file imports. https://phabricator.endlessm.com/T35494
Yep, it updates a bunch of .ttf.import files in GUT, adding I pushed 68522f8 just now with the new import files. I also checked if there's a newer version of GUT, and there is a newer version but I don't think it has anything relevant to 4.3. |
11657b5 to
bf1d181
Compare
dylanmccall
left a comment
There was a problem hiding this comment.
And I also went and added a matrix of Godot versions for running tests. The setup-godot hook is oddly persnickety about the Godot version ending with a .0 even though it doesn't actually anywhere else, but all's working :) There is in fact a failing test, which I can confirm fails on my end as well, so, yay, testing! We should fix that.
==============================================
= Run Summary
==============================================
res://tests/test_instruction_tree.gd
- test_multiple_entry_script
[Failed]: ["extends Node2D
func _ready():
print({text})
"] expected to equal ["extends Node2D
func _ready():
print({text})
print({text})
"]:
at line -1
---- Totals ----
Scripts 2
Tests 13
Passing 12
Failing 1
Asserts 520
Time 0.176s
---- 1 failing tests ----
bf1d181 to
2594c26
Compare
|
Yes, I see the test failing in my end as well, hmm. |
Duplicating the ready_block as ready_block_2 works with Godot 4.2, but fails with Godot 4.3. Looks like ready_block_2 does not have the following print_block properly. So, generate ready_block_2 and its print_block_2 from duplicated general_blocks: "ready" and "print" directly to avoid the issue with Godot 4.3. https://phabricator.endlessm.com/T35494
|
I pushed the commit ("Generate real nodes in test_multiple_entry_script()") to fix the error #197 (review). |
Excellent, thanks! |
|
I tried the different DuplicateFlags combinations and couldn't make this work. I wonder if we found a regression in 4.3 in the |
https://phabricator.endlessm.com/T35494