Merged
Conversation
dbnicholson
approved these changes
Aug 14, 2024
Contributor
Author
Good point! Although most of this is not in #147 I will add @wnbaum as co-author. |
dylanmccall
approved these changes
Aug 15, 2024
Contributor
dylanmccall
left a comment
There was a problem hiding this comment.
Yeah, I didn't spot any issues here either :)
These have variant type that it must be passed to the scene.
Like previously done for entry and statement blocks in 13e5700.
The resource file was missing.
Please note that the block name has changed slightly for the call methods. They are now: "call_method_group" and "call_method_node". But we are not considering this ABI yet. Also the node parameters have changed from NODE_PATH to OBJECT and the code templates have been simplified. They still work as before, passing node references like %UniqueName to the input field. Co-authored-by: Will Baumgartner <wnb@endlessos.org>
Co-authored-by: Will Baumgartner <wnb@endlessos.org>
And add missing defaults to the resource files. Please note that the type for arguments and return value have changed from integer to floating point. Co-authored-by: Will Baumgartner <wnb@endlessos.org>
And add missing defaults to the compare resource file. Co-authored-by: Will Baumgartner <wnb@endlessos.org>
And add the resource files for the block definitions.
And add the resource files for the block definitions.
8e329c0 to
5fa8e9d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This completes the port for blocks that don't depend on the node class.
Changes compared with #147:
https://phabricator.endlessm.com/T35591