Conversation
This fixes the zoom label being difficult to see with certain editor themes. #187
starnight
approved these changes
Aug 8, 2024
Contributor
starnight
left a comment
There was a problem hiding this comment.
Useful features! Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #186, this adds a feature which resets the editor zoom level and scroll position when the user clicks the zoom label (now button) in the bottom right corner. This is consistent with the zoom button in Godot's 2D editor, although for our purpose I felt better about always resetting the scroll position.
For #187, this changes the zoom label to use
CanvasItem.modulateinstead of overriding the text colour.