category_factory: Add pause, stop and continue audio feature#161
Merged
Conversation
manuq
requested changes
Jul 26, 2024
| b.statement = ( | ||
| """ | ||
| var __sound_node = get_node({name}) | ||
| __sound_node.stream_paused = true |
Contributor
There was a problem hiding this comment.
I wonder if we can follow the property setter/getter as returned by the static func property_to_blocklist() here, something like:
- Set sound Stream Paused to [True/False] (statement block)
- sound Stream Paused (parameter block)
This is to be closer to what GDScript does. See how Node "visible" property is handled, it is under "Graphics | Visibility" category.
In the future we should decide if we want to move the audio blocks to belong only to AudioStreamPlayer2D nodes only. Like the AnimationPlayer blocks.
Contributor
Author
There was a problem hiding this comment.
Good think! However, it needs to move all #region Sounds into get_built_in_blocks() which breaks the ABI. Because, it needs an AudioStreamPlayer node first. If we want to break the ABI in this release, I can do it.
Another easy way, like "animationplayer_play" block, have a parameter for selecting "Pause"/"Continue". I can modify the commit in this way first.
Contributor
There was a problem hiding this comment.
Good think! However, it needs to move all
#region Soundsintoget_built_in_blocks()which breaks the ABI. Because, it needs an AudioStreamPlayer node first. If we want to break the ABI in this release, I can do it.
Yes, I don't see why not, we are constantly breaking the format as this is still in early stage.
Another easy way, like "animationplayer_play" block, have a parameter for selecting "Pause"/"Continue". I can modify the commit in this way first.
OK!
0183ef9 to
fc8f192
Compare
manuq
approved these changes
Jul 29, 2024
starnight
added a commit
that referenced
this pull request
Jul 30, 2024
According to the discussion [1], move the sound blocks into function get_built_in_blocks()'s class matching. It generates blocks in GDScripts flavor, including setting the property's value. [1]: #161 (comment)
starnight
added a commit
that referenced
this pull request
Jul 30, 2024
According to the discussion [1], stream_paused is AudioStreamPlayer's a property. Use it as property flavor to generate blocks automatically. [1]: #161 (comment)
starnight
added a commit
that referenced
this pull request
Jul 30, 2024
According to the discussion [1], move the sound blocks into function get_built_in_blocks()'s class matching. It generates blocks in GDScripts flavor, including setting the property's value. [1]: #161 (comment)
starnight
added a commit
that referenced
this pull request
Jul 30, 2024
According to the discussion [1], stream_paused is AudioStreamPlayer's a property. Use it as property flavor to generate blocks automatically. [1]: #161 (comment)
starnight
added a commit
that referenced
this pull request
Jul 31, 2024
According to the discussion [1], move the sound blocks into function get_built_in_blocks()'s class matching. It generates blocks in GDScripts flavor, including setting the property's value. [1]: #161 (comment)
starnight
added a commit
that referenced
this pull request
Jul 31, 2024
According to the discussion [1], stream_paused is AudioStreamPlayer's a property. Use it as property flavor to generate blocks automatically. [1]: #161 (comment)
starnight
added a commit
that referenced
this pull request
Aug 1, 2024
According to the discussion [1], move the sound blocks into function get_built_in_blocks()'s class matching. It generates blocks in GDScripts flavor, including setting the property's value. [1]: #161 (comment)
starnight
added a commit
that referenced
this pull request
Aug 1, 2024
According to the discussion [1], stream_paused is AudioStreamPlayer's a property. Use it as property flavor to generate blocks automatically. [1]: #161 (comment)
starnight
added a commit
that referenced
this pull request
Aug 2, 2024
According to the discussion [1], move the sound blocks into function get_built_in_blocks()'s class matching. It generates blocks in GDScripts flavor, including setting the property's value. [1]: #161 (comment)
starnight
added a commit
that referenced
this pull request
Aug 2, 2024
According to the discussion [1], stream_paused is AudioStreamPlayer's a property. Use it as property flavor to generate blocks automatically. [1]: #161 (comment)
starnight
added a commit
that referenced
this pull request
Aug 5, 2024
According to the discussion [1], move the sound blocks into function get_built_in_blocks()'s class matching. It generates blocks in GDScripts flavor, including setting the property's value. [1]: #161 (comment)
starnight
added a commit
that referenced
this pull request
Aug 5, 2024
According to the discussion [1], stream_paused is AudioStreamPlayer's a property. Use it as property flavor to generate blocks automatically. [1]: #161 (comment)
starnight
added a commit
that referenced
this pull request
Aug 9, 2024
According to the discussion [1], move the sound blocks into function get_built_in_blocks()'s class matching. It generates blocks in GDScripts flavor, including setting the property's value. [1]: #161 (comment)
starnight
added a commit
that referenced
this pull request
Aug 9, 2024
According to the discussion [1], stream_paused is AudioStreamPlayer's a property. Use it as property flavor to generate blocks automatically. [1]: #161 (comment)
starnight
added a commit
that referenced
this pull request
Aug 9, 2024
According to the discussion [1], move the sound blocks into function get_built_in_blocks()'s class matching. It generates blocks in GDScripts flavor, including setting the property's value. [1]: #161 (comment)
starnight
added a commit
that referenced
this pull request
Aug 9, 2024
According to the discussion [1], stream_paused is AudioStreamPlayer's a property. Use it as property flavor to generate blocks automatically. [1]: #161 (comment)
starnight
added a commit
that referenced
this pull request
Aug 12, 2024
According to the discussion [1], move the sound blocks into function get_built_in_blocks()'s class matching. It generates blocks in GDScripts flavor, including setting the property's value. [1]: #161 (comment)
starnight
added a commit
that referenced
this pull request
Aug 12, 2024
According to the discussion [1], stream_paused is AudioStreamPlayer's a property. Use it as property flavor to generate blocks automatically. [1]: #161 (comment)
starnight
added a commit
that referenced
this pull request
Aug 13, 2024
According to the discussion [1], add the sound blocks into function get_built_in_blocks()'s class matching. It generates blocks belonging to AudioStreamPlayer node, including setting the property's value. Therfore, we have audio blocks in both types of general script and GDScript flavor. [1]: #161 (comment)
starnight
added a commit
that referenced
this pull request
Aug 13, 2024
According to the discussion [1], stream_paused is AudioStreamPlayer's a property. Use it as property flavor to generate blocks automatically. [1]: #161 (comment)
starnight
added a commit
that referenced
this pull request
Aug 13, 2024
According to the discussion [1], add the sound blocks into function get_built_in_blocks()'s class matching. It generates blocks belonging to AudioStreamPlayer node, including setting the property's value. Therfore, we have audio blocks in both types of general script and GDScript flavor. [1]: #161 (comment) https://phabricator.endlessm.com/T35609
starnight
added a commit
that referenced
this pull request
Aug 13, 2024
According to the discussion [1], stream_paused is AudioStreamPlayer's a property. Use it as property flavor to generate blocks automatically. [1]: #161 (comment) https://phabricator.endlessm.com/T35609
starnight
added a commit
that referenced
this pull request
Aug 13, 2024
According to the discussion [1], add the sound blocks into function get_built_in_blocks()'s class matching. It generates blocks belonging to AudioStreamPlayer node, including setting the property's value. Therfore, we have sound blocks in both types of general script and GDScript flavor. [1]: #161 (comment) https://phabricator.endlessm.com/T35609
starnight
added a commit
that referenced
this pull request
Aug 13, 2024
According to the discussion [1], stream_paused is AudioStreamPlayer's a property. Use it as property flavor to generate blocks automatically. [1]: #161 (comment) https://phabricator.endlessm.com/T35609
starnight
added a commit
that referenced
this pull request
Aug 14, 2024
According to the discussion [1], add the sound blocks into function get_built_in_blocks()'s class matching. It generates blocks belonging to AudioStreamPlayer node, including setting the property's value. Therfore, we have sound blocks in both types of general script and GDScript flavor. [1]: #161 (comment) https://phabricator.endlessm.com/T35609
starnight
added a commit
that referenced
this pull request
Aug 14, 2024
According to the discussion [1], stream_paused is AudioStreamPlayer's a property. Use it as property flavor to generate blocks automatically. [1]: #161 (comment) https://phabricator.endlessm.com/T35609
starnight
added a commit
that referenced
this pull request
Aug 14, 2024
According to the discussion [1], add the sound blocks into function get_built_in_blocks()'s class matching. It generates blocks belonging to AudioStreamPlayer node, including setting the property's value. Therfore, we have sound blocks in both types of general script and GDScript flavor. [1]: #161 (comment) https://phabricator.endlessm.com/T35609
jfcharron
pushed a commit
to jfcharron/godot-block-coding
that referenced
this pull request
Aug 14, 2024
According to the discussion [1], add the sound blocks into function get_built_in_blocks()'s class matching. It generates blocks belonging to AudioStreamPlayer node, including setting the property's value. Therfore, we have sound blocks in both types of general script and GDScript flavor. [1]: endlessm#161 (comment) https://phabricator.endlessm.com/T35609
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://phabricator.endlessm.com/T35582