Set MOUSE_FILTER_IGNORE for blocks where necessary#129
Merged
dbnicholson merged 1 commit intomainfrom Jul 13, 2024
Merged
Conversation
5158934 to
97dc618
Compare
dbnicholson
reviewed
Jul 12, 2024
| anchor_right = 1.0 | ||
| anchor_bottom = 1.0 | ||
| offset_right = -1152.0 | ||
| offset_bottom = -648.0 |
Member
There was a problem hiding this comment.
This seems unrelated. Is it intentional?
Contributor
Author
There was a problem hiding this comment.
Yeah, not intentional. Not sure what that's about - it doesn't really look right - but no reason to change it here. I removed that change now :)
Member
There was a problem hiding this comment.
Maybe it's something that was set in the scene at some point but actually had no effect? 🤷
dbnicholson
reviewed
Jul 12, 2024
| mouse_filter = 1 | ||
| script = ExtResource("2_lctqt") | ||
| color = Color(1, 1, 1, 1) | ||
| outline_color = Color(0.8, 0.8, 0.8, 1) |
Member
There was a problem hiding this comment.
Ack. I should have resaved this scene when removing the outline_color property in cc307af.
dbnicholson
reviewed
Jul 12, 2024
|
|
||
| [node name="SnapPoint" parent="VBoxContainer" instance=ExtResource("3_5vaov")] | ||
| layout_mode = 2 | ||
| block_path = NodePath("../..") |
dbnicholson
reviewed
Jul 12, 2024
Member
dbnicholson
left a comment
There was a problem hiding this comment.
I trust this is a good thing to do, but I don't understand why the SnapPoint offset was removed.
97dc618 to
91fe4ed
Compare
Certain components inside our Block scenes were consuming input events, making it difficult to interact with other blocks positioned around them.
91fe4ed to
e178d97
Compare
dbnicholson
approved these changes
Jul 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Certain components inside our Block scenes were consuming input events, making it difficult to interact with other blocks positioned around them.