Conversation
wnbaum
approved these changes
Jul 5, 2024
Contributor
wnbaum
left a comment
There was a problem hiding this comment.
Nice! Good thinking about BlockCode nodes that could be attached in instantiated scenes. Looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds some new warnings to
BlockCodeto deal with common problems users may encounter:Note that the "parent should only contain on BlockCode" warning also occurs when the parent is a separate (instantiated) scene. I simulated that in the screenshot by adding a
BlockCodenode to space.tscn, so in pong_game.tscn, where I added anotherBlockCodeunderSpace, we get a warning.