feat: add sponsors command#824
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
✅ Files skipped from review due to trivial changes (3)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds a new ChangesSponsors CLI Command
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Contributor
Greptile SummaryAdds a new
Confidence Score: 5/5Safe to merge — read-only stdout command with no auth, install, or dependency behavior changes. All changes are additive and isolated: a single new command that only calls println!, wired correctly into the dispatch table, with consistent help text and docs across every artifact. No files require special attention. Important Files Changed
Reviews (2): Last reviewed commit: "fix(sponsors): render cli docs" | Re-trigger Greptile |
Comment on lines
+7
to
+9
| println!( | ||
| "aube and the en.dev project family are sponsored by:\n\n 37signals - https://37signals.com\n\nView all sponsors: https://en.dev/sponsors.html\nSponsor en.dev: https://en.dev/sponsor.html" | ||
| ); |
Contributor
There was a problem hiding this comment.
Suggested change
| println!( | |
| "aube and the en.dev project family are sponsored by:\n\n 37signals - https://37signals.com\n\nView all sponsors: https://en.dev/sponsors.html\nSponsor en.dev: https://en.dev/sponsor.html" | |
| ); | |
| println!( | |
| "aube and the en.dev project family are sponsored by:\n\n 37signals - https://37signals.com\n\nView all sponsors: https://en.dev/sponsors.html\nSponsor en.dev: https://en.dev/sponsor.html" | |
| ); |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
There was a problem hiding this comment.
🧹 Nitpick comments (2)
crates/aube/src/commands/sponsors.rs (2)
7-9: 💤 Low valueConsider splitting the long string literal for better readability.
The current message spans over 170 characters in a single line, making it harder to read and maintain. Consider using a multi-line string or format macro.
♻️ Proposed refactor for readability
- println!( - "aube and the en.dev project family are sponsored by:\n\n 37signals - https://37signals.com\n\nView all sponsors: https://en.dev/sponsors.html\nSponsor en.dev: https://en.dev/sponsor.html" - ); + println!( + "aube and the en.dev project family are sponsored by:\n\n\ + 37signals - https://37signals.com\n\n\ + View all sponsors: https://en.dev/sponsors.html\n\ + Sponsor en.dev: https://en.dev/sponsor.html" + );🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@crates/aube/src/commands/sponsors.rs` around lines 7 - 9, The println! call in crates/aube/src/commands/sponsors.rs contains a very long single-line string; split it into a multi-line literal or concatenated pieces for readability by replacing the current println!( "...long string..." ) with a multi-line raw string (e.g., r#"..."#) or multiple shorter string literals joined in the same println! invocation, preserving the exact output and line breaks; target the println! invocation in this file to implement the change.
6-11: Confirm sponsor URLs resolve (HTTP 200) and optionally improve output readabilityAll three hardcoded sponsor links currently return HTTP 200:
The long
println!message could be reformatted/assembled for readability and maintainability.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@crates/aube/src/commands/sponsors.rs` around lines 6 - 11, The hardcoded sponsor URLs in the run(SponsorsArgs) function should be confirmed/resilient and the printed message made more readable/maintainable: validate (or note) that the three URLs (https://37signals.com, https://en.dev/sponsors.html, https://en.dev/sponsor.html) return 200 and then replace the single long println! with a clearer assembled message (e.g., build a const &str or multiline raw string and/or join a Vec<&str> of lines before printing) so the output is easy to maintain and edit; implement this change inside the run function to preserve behavior but improve readability and future editability.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@crates/aube/src/commands/sponsors.rs`:
- Around line 7-9: The println! call in crates/aube/src/commands/sponsors.rs
contains a very long single-line string; split it into a multi-line literal or
concatenated pieces for readability by replacing the current println!( "...long
string..." ) with a multi-line raw string (e.g., r#"..."#) or multiple shorter
string literals joined in the same println! invocation, preserving the exact
output and line breaks; target the println! invocation in this file to implement
the change.
- Around line 6-11: The hardcoded sponsor URLs in the run(SponsorsArgs) function
should be confirmed/resilient and the printed message made more
readable/maintainable: validate (or note) that the three URLs
(https://37signals.com, https://en.dev/sponsors.html,
https://en.dev/sponsor.html) return 200 and then replace the single long
println! with a clearer assembled message (e.g., build a const &str or multiline
raw string and/or join a Vec<&str> of lines before printing) so the output is
easy to maintain and edit; implement this change inside the run function to
preserve behavior but improve readability and future editability.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 53a37bb3-a846-48bf-8cca-ec7ce66b8520
📒 Files selected for processing (4)
README.mdcrates/aube/src/commands/mod.rscrates/aube/src/commands/sponsors.rscrates/aube/src/main.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sponsorscommand that acknowledges 37signals and links to the canonical en.dev sponsor pagesVerification
Note
Low Risk
Informational CLI output and README/docs only; no install, auth, or dependency behavior changes.
Overview
Adds a public
aube sponsorscommand that prints sponsor acknowledgment for 37signals and a link to the full en.dev sponsor list. The implementation is a small Rust handler wired through the usual CLI surfaces (main, command modules,aube.usage.kdl, and generated CLI docs).The root README gains a centered “Sponsored by 37signals” line with a link, matching the CLI messaging.
Reviewed by Cursor Bugbot for commit e02241c. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit
New Features
sponsorsCLI subcommand that displays sponsor information and links.Documentation
sponsorscommand.