test(resolver): cover alias peer cycle#813
Merged
Merged
Conversation
Contributor
Greptile SummaryAdds a timeout-guarded async regression test for the resolver's behavior when an npm alias sits inside a peer dependency cycle, mirroring the dep-path hang shape fixed in pnpm v11.5. No production code is modified.
Confidence Score: 5/5Test-only addition with no changes to production resolver logic; safe to merge. The change is a single new async test. The 5 s timeout matches the sibling cycle test, the alias package is asserted via a dep_path key lookup (not a value scan), and the fixture follows the established make_packument / pre-seeded cache pattern. No production code is touched. No files require special attention. Important Files Changed
Reviews (3): Last reviewed commit: "test(resolver): tighten alias peer cycle..." | Re-trigger Greptile |
7e39e13 to
83045e2
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
This PR was generated by Codex.
Note
Low Risk
Test-only change in
crates/aube-resolver/src/tests.rs; no production resolver logic modified in this diff.Overview
Adds a regression test in
aube-resolverfor resolver behavior when an npm alias sits in a peer dependency cycle, modeled on the pnpm v11.5 dep-path hang.The fixture wires root
alias-a→npm:real-a,real-apeers onb, andbpeers back onalias-awhile depending on the same alias. The test runsresolveunder a 5s timeout and asserts the graph finishes without hanging: the alias is keyed by its aliasdep_path, keepsalias_of/registry_name(), does not expose areal-a@…package key, and still resolvesb.Reviewed by Cursor Bugbot for commit 83045e2. Bugbot is set up for automated code reviews on this repo. Configure here.