fix(lockfile): preserve remote tarball integrity#812
Conversation
Greptile SummaryThis PR fixes a round-trip regression where direct HTTPS tarball dependencies in pnpm lockfiles lost their
Confidence Score: 5/5Safe to merge — the fix is narrowly scoped to hydrating remote tarball integrity from the packages block, mirrors the already-established git handling, and the new regression test confirms the primary parse→write round-trip works correctly. Both changes are additive and confined to the lockfile reader: the new RemoteTarball fallback arm follows the same structure as the Git arm it sits next to, and the matches! expansion is a one-operator change with no side effects on other source types. The write path was already correct; only the read side was missing the integrity assignment. No files require special attention. Important Files Changed
Reviews (2): Last reviewed commit: "fix(lockfile): preserve remote tarball i..." | Re-trigger Greptile |
77be90c to
850f2aa
Compare
Summary
Tests
This PR was generated by Codex.
Note
Low Risk
Scoped to pnpm lockfile read/hydration for direct remote tarballs; behavior mirrors existing git hydration with a focused regression test.
Overview
Direct HTTPS tarball dependencies in
pnpm-lock.yamlnow pullintegrity(and tarball metadata) from the matchingpackages:resolutionblock when the importer entry alone is not enough—using the same lookup pattern already used for git deps (match by package name + tarball URL).LockedPackage.integrityandRemoteTarballSource.integrityare kept on parse → write reuse so lockfile regeneration does not drop checksums for registry-style tarball URLs.A regression test covers a direct tarball importer spec and asserts the written lockfile still contains
integrityand thetarballURL.Reviewed by Cursor Bugbot for commit 850f2aa. Bugbot is set up for automated code reviews on this repo. Configure here.