refactor(install): split fetch pipeline#704
Conversation
517ac2e to
57b0c95
Compare
Greptile SummaryPure structural refactor that extracts the package fetch/import pipeline (~930 lines) from
Confidence Score: 5/5Safe to merge — the code is moved byte-for-byte; the PR's own validation (fmt, check, clippy, tests) covers the changed paths. Every function body in fetch.rs is a verbatim copy of what was in mod.rs; the only changes are module boundaries and import adjustments. The re-export visibility (pub(super) for fetch_packages) is semantically equivalent to pub(in crate::commands) from the sub-module's perspective, so no callers lose access. No files require special attention; both files are straightforward module restructuring with no logic edits. Important Files Changed
Reviews (1): Last reviewed commit: "refactor(install): split fetch pipeline" | Re-trigger Greptile |
What changed
commands/install/mod.rsintocommands/install/fetch.rs.install::fetch_packagesavailable for the siblingaube fetchcommand through the install module re-export.Why
This is a stacked follow-up to #702. After moving materialization, workspace, and critical-path helpers, the fetch/import pipeline was the next largest coherent chunk left in
install/mod.rs.Stacking
Base branch is
codex/refactor-install-pipelineso this PR shows only the fetch extraction. Once #702 merges, this branch can be rebased or retargeted ontomain.Validation
cargo fmt --checkcargo check -p aubecargo clippy -p aube --all-targets -- -D warningscargo test -p aube commands::installNote
Low Risk
Pure refactor that moves fetch/import logic into a new module and adjusts imports/re-exports; runtime behavior should be unchanged aside from potential integration regressions due to wiring changes.
Overview
Extracts the install fetch/import pipeline from
commands/install/mod.rsinto a newcommands/install/fetch.rsmodule, including local source imports (file/link/git/remote tarball), store index classification/caching, tarball download+integrity verification, and contextualized index remapping.Updates
install/mod.rsto declaremod fetch, re-exportfetch_packagesforaube fetch, and route existing install paths to the moved helpers, reducing the size ofmod.rswithout changing the install feature set.Reviewed by Cursor Bugbot for commit 57b0c95. Bugbot is set up for automated code reviews on this repo. Configure here.